vieiro commented on code in PR #6: URL: https://github.com/apache/netbeans-antora/pull/6#discussion_r1361132578
########## supplemental-ui/.htaccess: ########## @@ -1,25 +1,10 @@ DirectoryIndex index.html index.asciidoc -# former path to antora path -Redirect 301 /about/ /front/main/about/ Review Comment: The current page in our website is https://netbeans.apache.org/about/. All search engines have already indexed that page, so when a user searchs Google and is directed to the "/about/" page we want to behave nicely to them, this is, we do want to redirect them to "/front/main/about". So I would keep this one. ########## supplemental-ui/.htaccess: ########## @@ -1,25 +1,10 @@ DirectoryIndex index.html index.asciidoc -# former path to antora path -Redirect 301 /about/ /front/main/about/ -Redirect 301 /blogs/ /front/main/blogs/ -Redirect 301 /jackpot/ /front/main/jackpot/ -Redirect 301 /community/ /front/main/community/ -Redirect 301 /help/ /front/main/help/ -Redirect 301 /projects/ /front/main/projects/ -Redirect 301 /participate/ /front/main/participate/ -Redirect 301 /kb/ /tutorial/main/kb/ -Redirect 301 /tutorials/ /tutorial/main/tutorial/ -Redirect 301 /wiki/ /wiki/main/wiki/ Review Comment: Same thing for all of these. If a user is sent to "/wiki" from a search engine, we want to redirect the users to "/wiki/main/wiki" instead. So we want to keep these redirections. ########## supplemental-ui/.htaccess: ########## @@ -1,25 +1,10 @@ DirectoryIndex index.html index.asciidoc -# former path to antora path -Redirect 301 /about/ /front/main/about/ -Redirect 301 /blogs/ /front/main/blogs/ -Redirect 301 /jackpot/ /front/main/jackpot/ -Redirect 301 /community/ /front/main/community/ -Redirect 301 /help/ /front/main/help/ -Redirect 301 /projects/ /front/main/projects/ -Redirect 301 /participate/ /front/main/participate/ -Redirect 301 /kb/ /tutorial/main/kb/ -Redirect 301 /tutorials/ /tutorial/main/tutorial/ -Redirect 301 /wiki/ /wiki/main/wiki/ - - +# download from incubation Redirect 302 /download/9.0-beta/source https://archive.apache.org/dist/incubator/netbeans/incubating-netbeans-java/incubating-9.0-beta/incubating-netbeans-java-9.0-beta-source.zip Redirect 302 /download/9.0-beta/binary https://archive.apache.org/dist/incubator/netbeans/incubating-netbeans-java/incubating-9.0-beta/incubating-netbeans-java-9.0-beta-bin.zip -# former path to antora path after letting download to -Redirect 301 /download/ /front/main/download/ Review Comment: Keep this one too. ########## supplemental-ui/.htaccess: ########## @@ -92,6 +77,20 @@ RedirectMatch 301 ^/.?downloads/.*$ /download/index.html # Redirect plugin page to plugin portal Redirect 302 /plugins/index.html https://plugins.netbeans.apache.org/ +# former path to antora path after letting download to +Redirect 301 /about/ /front/main/about/ Review Comment: Ah, I see you keep the redirections here. Why the change from the top of the file to the bottom of the file? Is that important (order or redirections is important in .htaccess files, AFAIR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
