junichi11 commented on code in PR #6569:
URL: https://github.com/apache/netbeans/pull/6569#discussion_r1364044046
##########
php/php.editor/test/unit/data/testfiles/codegen/testIntersectionTypesImplementMethod03/testIntersectionTypesImplementMethod03.php.testIntersectionTypesImplementMethod03.codegen:
##########
@@ -1,2 +1,2 @@
-public function testMethod(\Test1\Foo&\Test1\Bar $param):
\Test1\Foo&\Test1\Bar{
+public function testMethod(Foo&Bar $param): \Test1\Foo&\Test1\Bar{
Review Comment:
https://github.com/apache/netbeans/blob/4086bd3bd687c616694d74f21aeab2ff6addc329/php/php.editor/test/unit/data/testfiles/codegen/testIntersectionTypesImplementMethod03/testIntersectionTypesImplementMethod03.php#L21-L42
Ideally, we should add
```php
public function testMethod(Foo&Bar $param): Foo&Bar {
}
```
then, add use statements. Maybe, users expect that, I think...
Users have to fix uses if we don't add namespaces like this. Should we add
FQNames like so far? (Of course, we also have to fix return types.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
