mbien commented on code in PR #6514:
URL: https://github.com/apache/netbeans/pull/6514#discussion_r1364206215
##########
java/maven/test/unit/src/org/netbeans/modules/maven/NbMavenProjectImplTest2.java:
##########
Review Comment:
I don't think this test will run in CI since the default include is probably
`*Test` or something similar
##########
java/maven/src/org/netbeans/modules/maven/NbMavenProjectImpl.java:
##########
@@ -303,6 +310,15 @@ public String getHintJavaPlatform() {
*/
//TODO revisit usage, eventually should be only reuse MavenProjectCache
public @NonNull MavenProject loadMavenProject(MavenEmbedder embedder,
List<String> activeProfiles, Properties properties) {
+ ProjectActionContext.Builder b = ProjectActionContext.newBuilder(this).
+ withProfiles(activeProfiles);
+ for (String pn : properties.stringPropertyNames()) {
+ b.withProperty(pn, properties.getProperty(pn));
+ }
Review Comment:
nitpick: more efficient if there are a lot of properties:
```java
for (Map.Entry<Object, Object> entry : properties.entrySet()) {
b.withProperty((String)entry.getKey(), (String)entry.getValue());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
