mbien commented on code in PR #6598: URL: https://github.com/apache/netbeans/pull/6598#discussion_r1367192263
########## extide/gradle/src/org/netbeans/modules/gradle/GradleConnectorManager.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.gradle; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.WeakHashMap; +import java.util.logging.Logger; +import org.gradle.tooling.GradleConnector; +import org.netbeans.api.project.Project; +import org.openide.modules.OnStop; + +/** + * + * @author lkishalmi + */ +public final class GradleConnectorManager { + + private final Map<Project, GradleConnector> projectConnector = new WeakHashMap<>(); + private final List<GradleConnector> connectors = new ArrayList<>(); + + private static final GradleConnectorManager INSTANCE = new GradleConnectorManager(); + private static final Logger LOG = Logger.getLogger(GradleConnectorManager.class.getName()); + + public static GradleConnectorManager getDefault() { + return INSTANCE; + } + + public GradleConnector getConnector(Project prj) { + synchronized (connectors) { + GradleConnector ret = projectConnector.computeIfAbsent(prj, p -> { + GradleConnector conn = GradleConnector.newConnector(); + connectors.add(conn); + return conn; + }); + return ret; + } + } + + + public void disconnectAll() { + LOG.info("Disconnecting from Gradle Daemons."); //NOI18N + synchronized (connectors) { + connectors.iterator().forEachRemaining(GradleConnector::disconnect); Review Comment: no problem at all! this is a fairly exotic method tbh. I believe the reason why it is named that way is because a iterator can be at an arbitrary position, so forEach could be misleading if it is not a fresh iterator. Also get some sleep 4h is not enough :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
