mbien commented on PR #6514: URL: https://github.com/apache/netbeans/pull/6514#issuecomment-1775592170
> Thanks @sdedic Any concerns still from comments above @mbien ? All being well, I will aim to merge tomorrow in time to sync for rc2. well, I am still worried to merge a non-trivial change like this so late (again) since it can have unexpected side effects. But since this has been tested https://github.com/apache/netbeans/pull/6514#issuecomment-1765971889 it should hopefully cause no trouble. I wished this could have been implemented in a simpler way, without hooking into the task event system if possible, but I had unfortunately no time to provide a full alternative implementation (beside this quick experiment https://github.com/apache/netbeans/pull/6514#discussion_r1349656909). We should try to clean up / refactor something every time we add complexity to the project otherwise this is going to get interesting. CI has already fairly low chances to complete without manual restarts, and this is after retry scripts etc. lets get this in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
