dragonsKnight5 commented on code in PR #6626:
URL: https://github.com/apache/netbeans/pull/6626#discussion_r1374047976
##########
ide/extbrowser/src/org/netbeans/modules/extbrowser/NbDdeBrowserImpl.java:
##########
@@ -212,7 +271,15 @@ private String realDDEServer () {
}
try {
- String cmd = getDefaultOpenCommand ();
+ String cmd = getDefaultOpenCommand();
+
+ /** if not found with getDefaultWindowsOpenCommand function
+ * fallback to previous method
+ */
+ if (cmd.isEmpty()) {
+ cmd = getDefaultOpenCommand();
+ }
+
Review Comment:
I think I was in to much of a rush to resubmit the pull request that I
managed to missed this
The previous method tries to work out the default browser by looking in
HKEY_CLASSES_ROOT at .html, the new method finds it by looking in
HKEY_CURRENT_USER at the userChoice for https.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
