mbien commented on PR #6596:
URL: https://github.com/apache/netbeans/pull/6596#issuecomment-1783881774
what anticipated performance issue is the rewrite in CHM supposed to
improve? The access pattern looks like there is probably not much contention
happening. Once the instances are in the map, the read operations should be
really fast while using synchronization since the critical sections are tiny.
the refactoring does also not get rid of many critical sections, e.g:
```
public boolean isEmpty() {
synchronized(delegate) {return delegate.isEmpty();}
}
```
so there would be more work left to finish it.
I usually would see concurrency updates a bit outside the scope of cleanups.
Is it worth spending the extra time in review for risky changes when the access
pattern is ending up to be get() after short initialization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
