mbien commented on code in PR #113:
URL:
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/113#discussion_r1382473880
##########
.github/workflows/ci.yml:
##########
@@ -0,0 +1,23 @@
+name: Verify
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ 8, 11, 17 ]
+ steps:
+ - uses: actions/checkout@v3
+ - name: "Set up JDK ${{ matrix.java }}"
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'temurin'
+ - name: Build & Test
+ run: ./mvnw -B verify -P run-its
Review Comment:
this repo does not have a lot of tests but it probably doesn't hurt to
append a test summary action:
```yml
- name: Create Test Summary
uses: mikepenz/action-junit-report@v4
if: always()
with:
annotate_only: true
detailed_summary: true
report_paths: 'nb*/target/surefire-reports/TEST-*.xml'
```
(I hope the path works - not tested)
we use `test-summary/action@v2` in the main repo which has slightly
different presentation - both have pros and cons
(https://github.com/apache/netbeans/pull/6462). We could try
`action-junit-report` here unless someone has a favorite.
##########
.github/workflows/ci.yml:
##########
@@ -0,0 +1,23 @@
+name: Verify
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ 8, 11, 17 ]
Review Comment:
21 seems to work, I suggest replacing 17 with 21 since it can be usually
implied that things work on 17 if they work on 21.
##########
.github/workflows/ci.yml:
##########
@@ -0,0 +1,23 @@
+name: Verify
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+
Review Comment:
we could add a concurrency section here, for the frequent-pushers:
```
# cancel other PR workflow run in the same head-base group if it exists
(e.g. during PR syncs)
# if this is not a PR run (no github.head_ref and github.base_ref defined),
use an UID as group
concurrency:
group: ${{ github.head_ref || github.run_id }}-${{ github.base_ref }}
cancel-in-progress: true
```
##########
.mvn/wrapper/maven-wrapper.jar:
##########
Review Comment:
i am not a fan of binaries in repos. I think the mvnw launcher script can
download this jar, right? We could use gh caching to be a nice internet citizen
if needed - but this is a low throughput repo, so I am not super worried about
that download atm :)
@neilcsmith-net what do you think?
##########
.github/workflows/ci.yml:
##########
@@ -0,0 +1,23 @@
+name: Verify
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ 8, 11, 17 ]
+ steps:
+ - uses: actions/checkout@v3
Review Comment:
->
```
- uses: actions/checkout@v4
with:
persist-credentials: false
submodules: false
show-progress: false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
