BradWalker commented on PR #5576: URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1793769619
Overall, I'm always in support of code cleanup. I would suggest that in the future you try and keep the changes in the same domain. This will make code review easier. For example.. 1 - If you say I'm going to clean up module XYZ, then it's appropriate to make a bunch of different changes in there. 2 - If you say I'm going to clean up the List generic, then keep the changes to cleaning up JUST the List interface. It becomes harder for a volunteer like me to do a code review when a bunch of unrelated changes are requested. Doesn't mean the changes aren't useful, it's just harder to read/understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
