tmysik commented on code in PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#discussion_r1387882407
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/DeclarationFinderImpl.java:
##########
@@ -397,6 +402,29 @@ private OffsetRange
getVarCommentOffsetRange(TokenSequence<PHPTokenId> ts, Strin
return null;
}
+ private Set<OffsetRange> getTypeRanges(String types, int startOffset) {
+ String[] splitTypes = Type.splitTypes(types);
+ Set<OffsetRange> ranges = new HashSet<>(splitTypes.length);
Review Comment:
Nitpick: please note that for `Set` (and `Map`), this ctor is a bit
different in comparison to the `List` one (sets or maps have load factor, by
default 0.75, so actually, the initial size should be bigger).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
