neilcsmith-net commented on code in PR #6695:
URL: https://github.com/apache/netbeans/pull/6695#discussion_r1392408294
##########
ide/gsf.testrunner.ui/src/org/netbeans/modules/gsf/testrunner/ui/ResultBar.java:
##########
@@ -48,18 +47,14 @@
* I was initially using a JProgressBar, with the BasicProgressBarUI
associated with it
* (to get red/green colors set correctly even on OSX), but it was pretty plain
* and ugly looking - no nice gradients etc. Hence this component.
- * @todo Add a getBaseline
*
* @author Tor Norbye
*/
public final class ResultBar extends JComponent implements ActionListener{
- private static final Color NOT_COVERED_LIGHT = new Color(255, 160, 160);
private static final Color NOT_COVERED_DARK = new Color(180, 50, 50);
- private static final Color COVERED_LIGHT = new Color(160, 255, 160);
private static final Color COVERED_DARK = new Color(30, 180, 30);
- private static final Color NO_TESTS_LIGHT = new Color(200, 200, 200);
+ private static final Color NO_TESTS_LIGHT = new Color(180, 180, 180);
Review Comment:
Good step in the right direction. Full marks if you make these UI keys too!
:smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
