mbien commented on code in PR #6747:
URL: https://github.com/apache/netbeans/pull/6747#discussion_r1406710835
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java:
##########
@@ -383,6 +383,17 @@ public enum ServerDetails {
"https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/7.0.9/glassfish-7.0.9.zip";,
// NOI18N
"https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/7.0.9/glassfish-7.0.9.zip";,
// NOI18N
"http://www.eclipse.org/legal/epl-2.0"; //NOI18N
+ ),
+
+ /**
+ * details for an instance of GlassFish Server 7.0.10
+ */
+ GLASSFISH_SERVER_7_0_10(NbBundle.getMessage(ServerDetails.class,
"STR_7010_SERVER_NAME", new Object[]{}), // NOI18N
+ GlassfishInstanceProvider.JAKARTAEE10_DEPLOYER_FRAGMENT,
+ GlassFishVersion.GF_7_0_10,
+
"https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/7.0.10/glassfish-7.0.10.zip";,
// NOI18N
+
"https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/7.0.10/glassfish-7.0.10.zip";,
// NOI18N
Review Comment:
could you switch the two new URLs to
https://repo.maven.apache.org/maven2/... ? It points to the same server but the
domain is managed by apache. I will do the same in other places so that
everything is standardized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
