jhorvath commented on code in PR #6746: URL: https://github.com/apache/netbeans/pull/6746#discussion_r1420185995
########## enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/AddDbConnectionToVault.java: ########## @@ -528,31 +626,34 @@ private void showInput(Step step, NotifyDescriptor desc) { } } - NotifyDescriptor prepareInput(NotifyDescriptor.ComposedInput input, int number) { + @Override + public NotifyDescriptor createInput(NotifyDescriptor.ComposedInput input, int number) { if (number == 1) { - steps.get(0).prepare(null); - return steps.get(0).createInput(); - } - if (steps.size() > number) { + while (steps.size() > 1) { + steps.removeLast(); + } + steps.getLast().prepare(null); + } else if (lastNumber > number) { steps.removeLast(); + while(steps.getLast().onlyOneChoice() && steps.size() > 1) { Review Comment: Intention of this loop is to skip steps where there is only one choice. This is correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists