mbien commented on code in PR #6844: URL: https://github.com/apache/netbeans/pull/6844#discussion_r1427806545
########## rust/rust.cargo/external/binaries-list: ########## @@ -0,0 +1,17 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +CB066A8E7E6E901824FE509BE16FD7974E20C700 net.vieiro:toml-java:1.1.1 Review Comment: cool! https://github.com/vieiro/toml-java/ ########## rust/rust.cargo/nbproject/project.properties: ########## @@ -15,5 +15,6 @@ # specific language governing permissions and limitations # under the License. +release.external/toml-java-1.1.1.jar=modules/ext/toml-java-1.1.1.jar javac.source=1.8 Review Comment: setting this to 11 should hopefully make the test pass ``` javac.source=11 javac.target=11 ``` failure: ``` testCheckClassFiles: org.netbeans.core.validation.ValidateClassFilesTest junit.framework.AssertionFailedError: found version 55.0 in net/vieiro/toml/TOMLSimpleQuery.class in D:\a\netbeans\netbeans\nbbuild\netbeans\rust\modules\ext\toml-java-1.1.1.jar found version 55.0 in net/vieiro/toml/TOMLParser.class in D:\a\netbeans\netbeans\nbbuild\netbeans\rust\modules\ext\toml-java-1.1.1.jar found version 55.0 in net/vieiro/toml/TOMLJSON.class in D:\a\netbeans\netbeans\nbbuild\netbeans\rust\modules\ext\toml-java-1.1.1.jar ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
