sdedic commented on code in PR #6843:
URL: https://github.com/apache/netbeans/pull/6843#discussion_r1429186005
##########
java/maven.embedder/nbproject/project.xml:
##########
@@ -319,9 +319,14 @@
<class-path-extension>
<runtime-relative-path>../maven/lib/httpcore-4.4.16.jar</runtime-relative-path>
</class-path-extension>
+ <!--
+ disable Maven's ANSI CLI decorations
+ maven-slf4j-provider injects MavenSimpleLogger which decorates the
output for terminal use
+ this causes problems in log files, tests etc which don't expect or
cant display them properly
<class-path-extension>
<runtime-relative-path>../maven/lib/jansi-2.4.0.jar</runtime-relative-path>
</class-path-extension>
+ -->
Review Comment:
Great !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists