tmysik commented on code in PR #6891:
URL: https://github.com/apache/netbeans/pull/6891#discussion_r1437678279
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/packets/FeatureSetResponse.java:
##########
@@ -43,6 +45,27 @@ public boolean isSuccess() {
@Override
public void process(DebugSession session, DbgpCommand command) {
+ if (command instanceof FeatureSetCommand) {
+ String feature = ((FeatureSetCommand) command).getFeature();
+ if
(feature.equals(FeatureGetCommand.Feature.BREAKPOINT_DETAILS.toString())) {
+ Node error = getChild(getNode(), ERROR);
+ if (error != null) {
Review Comment:
Nitpick: this whole condition can be perhaps a bit simplified:
```java
setSearchCurrentBreakpointById(session, error == null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
