mbien commented on code in PR #7001: URL: https://github.com/apache/netbeans/pull/7001#discussion_r1467619366
########## java/maven.embedder/external/binaries-list: ########## @@ -17,3 +17,4 @@ DC15DFF8F701B227EE523EEB7A17F77C10EAFE2F org.jdom:jdom2:2.0.6.1 5D9CE6ADD7B714B8095F0E3E396C5E9F8C5DCFEF org.apache.maven.shared:maven-dependency-tree:2.2 FC5C01A07E4A2DDF84AF0DFADF382E6F7993462D org.apache.maven:apache-maven:3.9.6:bin@zip +C4A06A64E650562F30B7BF9AAEC1BFED43ACA12B com.google.guava:failureaccess:1.0.2 Review Comment: lets take a look at the first level dependencies: NB 21 uses guava-32.1.2-jre right now, the pom of it is here: https://repo1.maven.org/maven2/com/google/guava/guava/32.1.2-jre/guava-32.1.2-jre.pom Looking at the pom, guava 32.1.2 was tested and released with failureaccess 1.0.1. To upgrade the failureaccess lib wrapper, I would recommend to update the guava lib wrapper itself to a version which depends on the desired failureaccess version (1.0.2). that would be 33.0.0-jre. https://repo1.maven.org/maven2/com/google/guava/guava/33.0.0-jre/guava-33.0.0-jre.pom So the guava lib wrapper 33.0.0 and failureaccess 1.0.2 lib wrapper would be updated in one atomic commit to versions which fit together. further, I think we should leave `java/maven.embedder` and gradle alone, since the update will automatically happen when the maven/gradle distribution updates. I think there are no other failureaccess users outside of guava - at least I can't find any. It is also part of the guava repo and no separate project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
