mbien commented on PR #7013:
URL: https://github.com/apache/netbeans/pull/7013#issuecomment-1915249710
@entlicher on what JDK versions should the mx project tests now run?
if its JDK 17 and 21 I suggest the following change:
```diff
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 8e28440..786f1bc 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -900,6 +900,12 @@
# - name: java/ant.grammar
# run: ant $OPTS -f java/ant.grammar test
+ # only JDK 17 and 21
+ - name: java/java.mx.project
+ if: ${{ matrix.java != '11' }}
+ continue-on-error: ${{ github.event_name != 'pull_request' }}
+ run: .github/retry.sh ant $OPTS -f java/java.mx.project test
+
- name: Set up JDK 17 for JDK 21 incompatible tests
if: ${{ matrix.java == '21' }}
uses: actions/setup-java@v4
@@ -908,10 +914,6 @@
distribution: ${{ env.default_java_distribution }}
# TODO fix JDK 21 incompatibilites
- - name: java/java.mx.project
- continue-on-error: ${{ github.event_name != 'pull_request' }}
- run: .github/retry.sh ant $OPTS -f java/java.mx.project test
-
- name: java/gradle.java
run: .github/retry.sh ant $OPTS -f java/gradle.java test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists