troizet commented on code in PR #6992:
URL: https://github.com/apache/netbeans/pull/6992#discussion_r1472738179


##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointModel.java:
##########
@@ -79,14 +86,37 @@ public String getDisplayName(Object node) throws 
UnknownTypeException {
             return builder.toString();
         } else if (node instanceof ExceptionBreakpoint) {
             ExceptionBreakpoint breakpoint = (ExceptionBreakpoint) node;
-            StringBuilder builder = new 
StringBuilder(NbBundle.getMessage(BreakpointModel.class, EXCEPTION));
+            StringBuilder builder = new StringBuilder();

Review Comment:
   Done.



##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java:
##########
@@ -27,6 +30,12 @@
  */
 public class ExceptionBreakpoint extends AbstractBreakpoint {
     private final String exceptionName;
+    @NullAllowed
+    private String message;
+    @NullAllowed
+    private String code;
+    private static final String FONT_GRAY_COLOR = "<font color=\"#999999\">"; 
//NOI18N
+    private static final String CLOSE_FONT = "</font>"; //NOI18N

Review Comment:
   Done.



##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/packets/RunResponse.java:
##########
@@ -57,4 +70,18 @@ private void updateBreakpointsView(DebugSession session, 
String id) {
         }
     }
 
+    private void setCurrentBreakpointText(DebugSession session, String 
message, String code) {
+        DebugSession.IDESessionBridge bridge = session.getBridge();
+        if (bridge != null) {
+            BreakpointModel breakpointModel = bridge.getBreakpointModel();
+            if (breakpointModel != null && 
breakpointModel.isSearchCurrentBreakpointById()) {
+                AbstractBreakpoint bp = 
breakpointModel.getCurrentBreakpoint(session);
+                if (bp != null && bp instanceof ExceptionBreakpoint) {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to