mbien commented on code in PR #7019:
URL: https://github.com/apache/netbeans/pull/7019#discussion_r1473590559


##########
harness/nbjunit/src/org/netbeans/junit/MethodOrder.java:
##########
@@ -43,6 +43,9 @@ static void initialize() {
         String orderS = findOrder();
         if (!"natural".equals(orderS)) { // NOI18N
             try {
+                // TODO: ClassLoader fields can not be accessed via reflection 
on JDK 12+
+                // see jdk.internal.reflect.Reflection#fieldFilterMap
+                // this won't work
                 Field classesF = 
ClassLoader.class.getDeclaredField("classes"); // NOI18N

Review Comment:
   luckily nothing seems to be using test case ordering: 
https://github.com/search?q=repo%3Aapache%2Fnetbeans%20NbTestCase.order&type=code
   
   so I haven't bothered to fix it. (I am also not sure if there is an easy 
fix, this might require instrumentation, a custom CL or some hooks into junit)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to