sdedic commented on PR #7063: URL: https://github.com/apache/netbeans/pull/7063#issuecomment-1947934398
Fixing the test was more tough than I expected. Why it failed: the Maven Problems inspector traverses artifacts (project.getArtifacts()), direct dependencies. Notes those that are not locally available. Earlier commits in this fix added "faked" artifacts created during project read. But I didn't pay attention to that these fakes are only created for POMs - not jars, but metadata of those jars. The resolver wrappers introduced by aaeabe1 allows to trace POM request back to the original artifact (which may have pom packaging !) and report that one. Final normalization of the missing artiact is done by ignoring artifact scope, as the scope is somewhat lost during the artifact resolution process - but it does not matter, the artifact was touched and needed during the project read. Without these steps, the Problems view either does not catch all problems, or displays duplicities (the same artifact in default and compile scope, for example). Maybe the problem reporter could be rewritten to use recursive dependencies, or rely on Maven reading infrastructure with catching errors in resolver wrappers, so the info comes from a single source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
