sdedic commented on code in PR #7076:
URL: https://github.com/apache/netbeans/pull/7076#discussion_r1494498369


##########
java/maven/src/org/netbeans/modules/maven/customizer/CustomizerProviderImpl.java:
##########
@@ -415,10 +414,6 @@ private static void writeNbActionsModel(final Project 
project, final FileObject
             @Override
             public void run() throws IOException {
                 JDOMFactory factory = new DefaultJDOMFactory();
-                
-                InputStream inStr = null;
-                FileLock lock = null;
-                OutputStreamWriter outStr = null;
                 try {
                     Document doc;
                     if (mapping.getActions().isEmpty()) { //#224450 don't 
write empty nbactions.xml files

Review Comment:
   Please retain the `FileLock` for fo, as it prevents concurrent overwrite of 
`fo` contents after for is read and before a modified version is written.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to