lahodaj commented on code in PR #7087: URL: https://github.com/apache/netbeans/pull/7087#discussion_r1497025148
########## java/maven.indexer/external/lucene-9.10.0-license.txt: ########## @@ -1,11 +1,11 @@ Name: Apache Lucene Description: Java-based indexing and search technology -Version: 9.9.1 +Version: 9.10.0 Origin: Apache Software Foundation License: Apache-2.0 URL: https://lucene.apache.org/ Source: https://github.com/apache/lucene -Files: lucene-analysis-common-9.9.1.jar lucene-backward-codecs-9.9.1.jar lucene-core-9.9.1.jar lucene-highlighter-9.9.1.jar lucene-queryparser-9.9.1.jar +Files: lucene-analysis-common-9.10.0.jar lucene-backward-codecs-9.10.0.jar lucene-core-9.10.0.jar lucene-highlighter-9.10.0.jar lucene-queryparser-9.10.0.jar Apache License Review Comment: So, while here, it would probably be good to fix the license text. If I look e.g. inside the `lucene-analysis-common-9.10.0.jar`, I see `META-INF/LICENSE.txt`, which contains a lot more text than what's here (as here is Apache 2.0 only). As a side note, the license text in `lucene-analysis-common-9.10.0.jar/META-INF/LICENSE.txt` is not completely correct, to my knowledge: the NOTICE.txt says this: > The German,Spanish,Finnish,French,Hungarian,Italian,Portuguese,Russian and Swedish light stemmers (common) are based on BSD-licensed reference implementations created by Jacques Savoy and Ljiljana Dolamic. These files reside in: at least some of the files listed below this note seem to be included in the jar (in compiled form), but there's no license text for this in LICENSE.txt. Based on history, I assume we want be fixing those, but its worth noting, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
