mbien commented on PR #7055: URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1962335042
hi @febilus, you did good since I see only one commit in your branch - so the squashing worked. the branch is a few weeks old but I think this shouldn't matter here since the Wildfly area has low traffic. in future: lets say the PR is reviewed and someone asks you to squash the PR to make it ready to integration you can do the following: you could update your branch (rewrite history) and put your commits on top of latest changes **without a merge commit**, all you have to do is: ``` git pull --rebase [email protected]:apache/netbeans master ``` (this assumes you have the PR branch checked out) (you can also use origin alias if it points at the apache repo) (this will also get rid of any existing merge commits, if there are any) Now its easy to squash the commits however you like them to be (in most cases it will be just one commit). Also keep in mind other projects might have a different policy, some don't allow force pushes and let the person who integrates the PR squash it etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
