Chris2011 commented on code in PR #4485:
URL: https://github.com/apache/netbeans/pull/4485#discussion_r1511734160
##########
ide/csl.api/test/unit/src/org/netbeans/modules/csl/api/test/CslTestBase.java:
##########
@@ -4384,8 +4384,11 @@ protected ComputedHints computeHints(final NbTestCase
test, final Rule hint, Str
}
}
if (HintsSettings.getSeverity(manager, ucr) ==
HintSeverity.CURRENT_LINE_WARNING) {
- manager.setTestingRules(null,
Collections.EMPTY_MAP, testHints, null);
+ manager.setTestingRules(null, testHints,
testHints, null);
provider.computeSuggestions(manager, context,
hints, caretOffset);
+ } else if(HintsSettings.getSeverity(manager, ucr) ==
HintSeverity.ERROR || HintsSettings.getSeverity(manager, ucr) ==
HintSeverity.WARNING) {
+ manager.setTestingRules(null, testHints,
testHints, null);
+ provider.computeErrors(manager, context, hints,
new ArrayList<Error>());
Review Comment:
No, not yet. I just thought that the pipes will show me the result and I
just saw some failing tests of Latte. PHP where not triggert here at github
inside my branch. I will just revert this change as you said and will try to
implement a better logic into the HtmlHintsProvider as similiar as for PHP and
JS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
