lkishalmi commented on code in PR #7097:
URL: https://github.com/apache/netbeans/pull/7097#discussion_r1522538075
##########
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/HCLSemanticAnalyzer.java:
##########
@@ -87,25 +85,33 @@ public void cancel() {
cancelled = true;
}
- protected abstract class Highlighter extends HCLElement.BAEVisitor {
- protected final Map<OffsetRange, Set<ColoringAttributes>> work = new
HashMap<>();
+ protected abstract class Highlighter {
+ protected final Map<OffsetRange, Set<ColoringAttributes>> work = new
IdentityHashMap<>();
Review Comment:
No it turned out that's not really needed. the `HashMap` ->
`IdentityHashMap` change was required only in `SourceRef` the record generated
hash codes seemed to be "too perfect", causing troubles in coloring.
Will revert back to `HashMap` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
