mbien commented on code in PR #7164:
URL: https://github.com/apache/netbeans/pull/7164#discussion_r1527129974
##########
ide/o.n.swing.dirchooser/src/org/netbeans/swing/dirchooser/DirectoryChooserUI.java:
##########
@@ -296,9 +299,16 @@ private void updateUseShellFolder() {
}
}
- /** Returns instance of WindowsPlacesBar class or null in case of failure
+ /**
+ * Returns a shortcuts panel, e.g the windows places bar or the NB
favorites shortcuts panel
*/
- private JComponent getPlacesBar () {
+ private JComponent getPlacesBar() {
+ if (useNBShortcutsPanel()) {
+ FlatShortcutsPanel shortcuts = new FlatShortcutsPanel(fileChooser);
+ JScrollPane sp = new JScrollPane(shortcuts,
JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED,
JScrollPane.HORIZONTAL_SCROLLBAR_NEVER);
+ sp.setPreferredSize(new Dimension(100, 300));
+ return sp;
+ }
Review Comment:
@DevCharly do you think it would make sense for FlatLaf to wrap the
`FlatShortcutsPanel` in a JScrollPane like here?
NB uses two file choosers, one is customized and used for opening projects
etc, the other one is the standard JDK file chooser. Now when the shortcuts
panel has lots of items the standard JDK file chooser will get very tall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
