mbien commented on PR #7155: URL: https://github.com/apache/netbeans/pull/7155#issuecomment-2002310563
sorry that I change things after it was already reviewed but I found a few more things to do after debugging. When looking through `IncludeExclude` (which is a quite risky implementation), I noticed that the class isn't called at all. Turns out that the whole https://github.com/apache/netbeans/blob/bbd18aa9369eca4d8c32e6ffab29940347d260a4/nb/o.n.upgrader/src/org/netbeans/upgrade/Copy.java#L33 class isn't used. `AutoUpgrade` is only using `CopyFiles`. and once its done `Import` is called. `CopyFiles` has its own implementation of the import/exclude logic. now the question is: should we remove more? `Copy`, `IncludeExclude`, `PathTransformation`+ tests? Or merge as is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
