mbien commented on code in PR #7128:
URL: https://github.com/apache/netbeans/pull/7128#discussion_r1531585909
##########
ide/versioning.util/src/org/netbeans/modules/versioning/history/SummaryCellRenderer.java:
##########
@@ -714,16 +735,20 @@ private String prepareText (String text) {
private class EventRenderer extends JPanel implements ListCellRenderer {
private boolean lastSelection = false;
+ private String lastSearch = null;
+ private int lastShowingFiles = -1;
private final JLabel pathLabel;
private final JLabel actionLabel;
private final JButton actionButton;
private String id;
private final String PATH_COLOR =
getColorString(lessInteresting(UIManager.getColor("List.foreground"),
UIManager.getColor("List.background"))); //NOI18N
+ private final String SEARCH_COLOR_BG = getColorString((Color)
Objects.requireNonNullElse(searchHiliteAttrs.getAttribute(StyleConstants.Background),
Color.BLUE)); //NOI18N
+ private final String SEARCH_COLOR_FG = getColorString((Color)
Objects.requireNonNullElse(searchHiliteAttrs.getAttribute(StyleConstants.Foreground),
UIManager.getColor("List.foreground"))); //NOI18N
public EventRenderer () {
pathLabel = new JLabel();
actionLabel = new JLabel();
- actionButton = new LinkButton("..."); //NOI18N
+ actionButton = new LinkButton("=>"); //NOI18N
Review Comment:
I wasn't sure about that one myself. But the `...` looked tiny and I
initially misunderstood it that it meant that the content didn't fit into the
cell and/or the layout was broken. I have no hard feelings about this, but
would be curious what others prefer - I can change it back thats no problem.
Unicode has lots of symbols these days, I am wondering if there is something
else which intuitively makes sense as something you can click on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
