mbien commented on code in PR #7181:
URL: https://github.com/apache/netbeans/pull/7181#discussion_r1536608775
##########
.github/workflows/main.yml:
##########
@@ -2419,6 +2414,8 @@ jobs:
matrix:
java: [ '17' ]
os: [ 'windows-latest', 'ubuntu-latest' ]
+ exclude:
+ - os: ${{ contains(github.event.pull_request.labels.*.name, 'PHP')
|| contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }} && 'nothing' || 'windows-latest' }}
Review Comment:
this looks a bit complicated but what it does is to only run PHP tests on
`ubuntu-latest` if the https://github.com/apache/netbeans/labels/ci%3Aall-tests
or https://github.com/apache/netbeans/labels/PHP label is not set. Outside of
PRs (e.g on master), or when the label is set, it will run on both win+linux as
before.
Why linux? We can run the xserver there + linux nodes are a bit faster.
##########
.github/workflows/main.yml:
##########
@@ -2433,7 +2430,7 @@ jobs:
if: contains(matrix.os, 'ubuntu')
uses: shivammathur/setup-php@v2
with:
- php-version: '7.4'
+ php-version: '8.3'
Review Comment:
@junichi11 I bumped the PHP version so that we don't test on EOL releases -
lets see if it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
