mbien commented on code in PR #7182: URL: https://github.com/apache/netbeans/pull/7182#discussion_r1536870485
########## java/maven/nbproject/project.properties: ########## @@ -34,7 +34,7 @@ test.config.stableBTD.excludes=\ jnlp.indirect.files=maven-nblib/netbeans-eventspy.jar,maven-nblib/netbeans-cos.jar -# requires nb.javac for compiling of tests +# TODO remove after JDK 17 bump (code uses CompilationUnitTree#getModule) requires.nb.javac=true Review Comment: since gradle is going to be 17+, maybe we should do this here too. I saw some sig validation issues in the log when I tried this so I didn't really bother. However that was before https://github.com/apache/netbeans/pull/7117, maybe I should give it another try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
