mbien commented on PR #7186: URL: https://github.com/apache/netbeans/pull/7186#issuecomment-2017708952
+1 to the effort generating grammar during build > So, for instance, we may run ant download-antlr-grammar whenever we upgrade ide/libs.antlr4.runtime, and not on each build. +1 This sounds like a super important thing we should do, otherwise issues could suddenly start appearing and we don't know why. However I think we have to discuss one thing: having code generated during build does not automatically exclude having it also checked into the repo. I have a slight preference of not checking generated code in, however the safer approach in big projects with many cooks and imperfect code coverage is to check everything in. I don't have the experience to know how much noise this would cause, however, with @vieiro's point above this might be an option, since we should only see changes to generated code during lib upgrades - hopefully not during builds on different systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
