vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2027971594
> Well I'd keep the `JsonBaseListener` and `JsonBaseVisitor` interfaces, mark them `@Deprecated`, maybe even for removal. Though right now they are just a compatibility layer of the ANTLR4 generated interfaces. (See: [#4845 (comment)](https://github.com/apache/netbeans/pull/4845#issuecomment-1288019365)) Well, the API is exported to friend modules only (currently 3: `o.n.m.javascript2.[editor,lexer,model]`) and these have been already upgraded, so I don't see a reason to keep 4.11.1 generated code around. But hey, if you want to keep these for another release then that's OK for me. I'll modify the last commit in a few hours. Also I'll fire a new ci-all-tests CI check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
