eirikbakke commented on code in PR #6577:
URL: https://github.com/apache/netbeans/pull/6577#discussion_r1545756417
##########
platform/core.windows/src/org/netbeans/core/windows/services/NbPresenter.java:
##########
@@ -503,20 +500,12 @@ public int getMaxCharactersPerLineCount() {
);
}
- if (UIManager.getLookAndFeel().getClass() == MetalLookAndFeel.class ||
- UIManager.getLookAndFeel().getClass() == BasicLookAndFeel.class) {
- optionPane.setUI(new javax.swing.plaf.basic.BasicOptionPaneUI() {
- @Override
- public Dimension getMinimumOptionPaneSize() {
- if (minimumSize == null) {
- //minimumSize =
UIManager.getDimension("OptionPane.minimumSize");
- // this is called before defaults initialized?!!!
- return new Dimension(MinimumWidth, 50);
- }
- return new Dimension(minimumSize.width, 50);
- }
- });
- }
+ // TODO move to a better place, only for testing
Review Comment:
I can defer to your opinion here. Customization is only necessary if you
think someone will need to customize it.
My own NetBeans Platform app has been using a patched version of this class
for 2 years (the one from https://github.com/apache/netbeans/pull/5335 ), and
if the official version doesn't end up working for me, I'll just keep using my
old patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
