matthiasblaesing commented on PR #7198: URL: https://github.com/apache/netbeans/pull/7198#issuecomment-2028930014
> > I would not have made api incompatible changes in mercurial, but given that the "API" is friend-only with a single user > > I must have misunderstood your review comment then. What is the friend export you are worried about? There is still time to revert things. Sorry for the misunderstanding. My final comment was directed at the changes in `ide/mercurial/src/org/netbeans/modules/mercurial/api/Mercurial.java`. I don't remember, that they were in the original changeset (or I overlooked them). My first glance trigger my "API!!!"-reflex (from package name) and the second look then showed that the mercurial module has no public api. It is done and cleanup, so I suggest to keep the change and merge as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
