matthiasblaesing commented on code in PR #7250:
URL: https://github.com/apache/netbeans/pull/7250#discussion_r1558072762
##########
ide/libs.graalsdk/src/org/netbeans/libs/graalsdk/impl/GraalEnginesProvider.java:
##########
@@ -60,7 +61,9 @@ public List<ScriptEngineFactory>
factories(ScriptEngineManager m) {
if (disable == null) {
enumerateLanguages(arr, m == null ? null : m.getBindings());
}
- } catch (IllegalStateException | LinkageError err) {
+ } catch (IllegalStateException | LinkageError |
ServiceConfigurationError err) {
+ // See NETBEANS #7245: First-time initialization with broken
implementation may produce ServiceConfigurationError, As this
+ // happens in class-initializer, subsequent attempts will throw
LinkageErrors.
Review Comment:
Thank you - indeed a more focused fix, bringing a partitial solution with
minimal/no negative side effects. At this point however I think it would be
helpful to also have logging as in `Scripting.java`. Adding the catch clause
for `ServiceConfigurationError` fixes the problem reported in #7245 (not being
able to generate a HTML/JS application), but there is also no info shown, as
the exception is swallowed. This also does not need an additional guard as the
code that could cause the exceptions is entered at most once (`disable` is used
as guard).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
