mbien commented on code in PR #7253:
URL: https://github.com/apache/netbeans/pull/7253#discussion_r1560290662
##########
webcommon/libs.graaljs/external/js-24.0.0-license.txt:
##########
Review Comment:
i am no license expert so I can't comment on that, but i would likely have
taken the GPL+CPE of the community edition
##########
java/nashorn.execution/test/unit/src/org/netbeans/modules/nashorn/execution/JSExecutorTest.java:
##########
@@ -46,7 +46,7 @@ public void testLoadAllGraalJsLibraries() throws Exception {
find.setAccessible(true);
final ClassPath cp = (ClassPath) find.invoke(null);
final FileObject[] roots = cp.getRoots();
- assertEquals("Seven roots", 7, roots.length);
+ assertEquals("Seven roots", 11, roots.length);
Review Comment:
nitpick: "11 roots expected"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
