mbien commented on code in PR #7206:
URL: https://github.com/apache/netbeans/pull/7206#discussion_r1564881067
##########
.github/workflows/main.yml:
##########
@@ -73,29 +87,30 @@ env:
# 'Platform' label
test_platform: ${{ contains(github.event.pull_request.labels.*.name,
'Platform') || contains(github.event.pull_request.labels.*.name,
'ci:all-tests') || github.event_name != 'pull_request' }}
- # 'tests' label for building all tests
- test_tests: ${{ contains(github.event.pull_request.labels.*.name, 'tests')
|| contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
-
# 'LSP' label for enabling Language Server Protocol tests
- test_lsp: ${{ contains(github.event.pull_request.labels.*.name, 'LSP') ||
contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
+ # 'Gradle' or 'Maven' will activate lsp tests too due to test dependencies
on project API (ProjectViewTest, LspBrokenReferencesImplTest, ...)
+ test_lsp: ${{ contains(github.event.pull_request.labels.*.name, 'LSP') ||
contains(github.event.pull_request.labels.*.name, 'Gradle') ||
contains(github.event.pull_request.labels.*.name, 'Maven') ||
contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
Review Comment:
lsp job is now also active with
https://github.com/apache/netbeans/labels/Gradle or
https://github.com/apache/netbeans/labels/Maven due to test dependencies to
project API.
This was added to avoid issues like
https://github.com/apache/netbeans/pull/7267 in future. Anything else to change?
@lkishalmi @sdedic @neilcsmith-net
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
