matthiasblaesing commented on code in PR #7269: URL: https://github.com/apache/netbeans/pull/7269#discussion_r1566244043
########## ide/go.lang/nbproject/project.properties: ########## @@ -16,7 +16,10 @@ # under the License. javac.source=1.8 -# As of 2nd Jan 2023, we use the Grammar from: -# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang +# As of 14th April 2024, we use the Grammar from: +# https://github.com/antlr/grammars-v4/tree/bcc9ec1b35e4ede2f90abdb8713a56315a634a92/golang # -golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d +golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92 + +# Simple language update can result too many signature changes in the generated code. +sigtest.skip.gen=true Review Comment: Why drop the pretense, that this is module has an API and require that users make dependencies implementation dependencies? ########## ide/go.lang/nbproject/project.properties: ########## @@ -16,7 +16,10 @@ # under the License. javac.source=1.8 -# As of 2nd Jan 2023, we use the Grammar from: -# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang +# As of 14th April 2024, we use the Grammar from: +# https://github.com/antlr/grammars-v4/tree/bcc9ec1b35e4ede2f90abdb8713a56315a634a92/golang # -golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d +golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92 + +# Simple language update can result too many signature changes in the generated code. +sigtest.skip.gen=true Review Comment: Why drop the pretense that this is module has an API and require that users make dependencies implementation dependencies? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
