jgneff commented on PR #7283: URL: https://github.com/apache/netbeans/pull/7283#issuecomment-2067537797
Thanks, Michael. I would like this to go into NetBeans 22, if at all possible, but I'm not able to add any labels. The build of NetBeans 22 fails for me without this fix (as it did for the same problem in 2022 and 2023). > Depends what you are trying to do ;) `master` would target NB 23 right now, `delivery` is essentially bugfix/lowrisk-only and targets NB 22 which is in the release candidate phase. I figured it out. (See **UPDATE** above.) I didn't realize you could edit the *base* branch in addition to the PR title when you click the Edit button at the top of the pull request on GitHub. > Regarding changing the target branch of a PR: your branch should be a copy of the branch you are targeting. So if you target `delivery`, make sure your commit is on top of a copy of the delivery branch. I did that. I just forgot to change the base branch on the GitHub pull request. GitHub sets the base branch to the *master* branch no matter what you have for the actual base of your pull request branch, it seems. > You don't have to close the PR, you can simply force push into your branch (`-f`), github will catch up. Didn't even have to do that. I just switched it in GitHub to match what I had actually done locally, which is to base my pull request branch on the *delivery* branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
