mbien commented on PR #7315: URL: https://github.com/apache/netbeans/pull/7315#issuecomment-2071468222
> Gonna be hasty with pull requests next time after the article is published. hi @LiakhovD, no need to rush anything. Simply get in touch via issue/discussion/mailing list and say that you are planning to open a PR next time. It was a coincidence that I saw the article (someone PMed me the link via slack), I didn't look at the date - I simply assumed that there won't be any followup after checking PRs and mails so I did it myself via #7284. Luckily a lot of this was dead code or an edge case with little impact (e.g one issue would swap left and right of the diff view under certain conditions), at least one other hit was already fixed in master at this point. But the blog post was good inspiration to run some inspections myself, e.g I found some more endless recursion cases by running the NetBeans inspection on the code base or by checking for other patterns with a jackpot rule. I left a few things out which are inactive/or should be removed anyway (jnlp related code). The most interesting case to me was probably the loop in `SchemaReferenceProxy.java`, although I didn't have time to check under what conditions the code runs. And yeah one dev really liked using `!!!` almost 25 years ago. We should preserve those snippets via protected code blocks for future generations ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
