sdedic commented on code in PR #7371:
URL: https://github.com/apache/netbeans/pull/7371#discussion_r1596698296
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/DownloadWalletDialog.java:
##########
@@ -335,6 +337,10 @@ public char[] getDbPassword() {
public String getOcid() {
return ocid;
}
+
+ public String getComaprtmentOcid() {
Review Comment:
Nitpick-naming: `compartment` or `compartmentId` is used elsewhere.
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/bucket/BucketNode.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.bucket;
+
+import com.oracle.bmc.objectstorage.ObjectStorageClient;
+import com.oracle.bmc.objectstorage.requests.ListBucketsRequest;
+import java.util.stream.Collectors;
+import org.netbeans.modules.cloud.oracle.ChildrenProvider;
+import org.netbeans.modules.cloud.oracle.NodeProvider;
+import org.netbeans.modules.cloud.oracle.OCIManager;
+import org.netbeans.modules.cloud.oracle.OCINode;
+import org.netbeans.modules.cloud.oracle.compartment.CompartmentItem;
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.openide.util.NbBundle;
+
+/**
+ *
+ * @author Jan Horvath
+ */
[email protected]({})
+public class BucketNode extends OCINode {
+
+ private static final String BUCKET_ICON =
"org/netbeans/modules/cloud/oracle/resources/bucket.svg"; // NOI18N
+
+ public BucketNode(BucketItem bucket) {
+ super(bucket);
+ setName(bucket.getName());
+ setDisplayName(bucket.getName());
+ setIconBaseWithExtension(BUCKET_ICON);
+ setShortDescription("Bucket: " + bucket.getName());
Review Comment:
I18N
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/compute/ComputeInstanceNode.java:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.compute;
+
+import com.oracle.bmc.core.ComputeClient;
+import com.oracle.bmc.core.model.Instance;
+import com.oracle.bmc.core.requests.ListInstancesRequest;
+import java.util.stream.Collectors;
+import org.netbeans.modules.cloud.oracle.ChildrenProvider;
+import org.netbeans.modules.cloud.oracle.NodeProvider;
+import org.netbeans.modules.cloud.oracle.OCIManager;
+import org.netbeans.modules.cloud.oracle.OCINode;
+import org.netbeans.modules.cloud.oracle.compartment.CompartmentItem;
+import org.netbeans.modules.cloud.oracle.items.OCID;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class ComputeInstanceNode extends OCINode {
+ private static final String COMPUTE_INSTANCE_ICON =
"org/netbeans/modules/cloud/oracle/resources/computeinstance.svg"; // NOI18N
+
+ public ComputeInstanceNode(ComputeInstanceItem instance) {
+ super(instance);
+ setName(instance.getName());
+ setDisplayName(instance.getName());
+ setIconBaseWithExtension(COMPUTE_INSTANCE_ICON);
+ setShortDescription("Compute Instance: " + instance.getName());
+ }
+
+ public static NodeProvider<ComputeInstanceItem> createNode() {
+ return ComputeInstanceNode::new;
+ }
+
+ /**
+ * Retrieves list of Vaults belonging to a given Compartment.
+ *
+ * @return Returns {@code ChildrenProvider} which fetches List of
+ * {@code BucketItem} for given {@code CompartmentItem}
+ */
+ public static ChildrenProvider<CompartmentItem, ComputeInstanceItem>
getComputeInstances() {
+ return compartmentId -> {
+ ComputeClient client =
ComputeClient.builder().build(OCIManager.getDefault().getActiveProfile().getConfigProvider());
+
+ ListInstancesRequest listInstancesRequest =
ListInstancesRequest.builder()
+ .compartmentId(compartmentId.getKey().getValue())
+ .limit(88)
+ .build();
+
+ return client.listInstances(listInstancesRequest)
+ .getItems()
+ .stream()
+ .filter(c ->
!c.getLifecycleState().equals(Instance.LifecycleState.Terminated))
Review Comment:
Is there some way how to view created-but-inactive compute instances in the
browser ? if not, we could keep this as RFE for future enhancement.
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/bucket/BucketNode.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.bucket;
+
+import com.oracle.bmc.objectstorage.ObjectStorageClient;
+import com.oracle.bmc.objectstorage.requests.ListBucketsRequest;
+import java.util.stream.Collectors;
+import org.netbeans.modules.cloud.oracle.ChildrenProvider;
+import org.netbeans.modules.cloud.oracle.NodeProvider;
+import org.netbeans.modules.cloud.oracle.OCIManager;
+import org.netbeans.modules.cloud.oracle.OCINode;
+import org.netbeans.modules.cloud.oracle.compartment.CompartmentItem;
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.openide.util.NbBundle;
+
+/**
+ *
+ * @author Jan Horvath
+ */
[email protected]({})
+public class BucketNode extends OCINode {
+
+ private static final String BUCKET_ICON =
"org/netbeans/modules/cloud/oracle/resources/bucket.svg"; // NOI18N
+
+ public BucketNode(BucketItem bucket) {
+ super(bucket);
+ setName(bucket.getName());
+ setDisplayName(bucket.getName());
+ setIconBaseWithExtension(BUCKET_ICON);
+ setShortDescription("Bucket: " + bucket.getName());
+ }
+
+ public static NodeProvider<BucketItem> createNode() {
+ return BucketNode::new;
+ }
+
+ /**
+ * Retrieves list of Vaults belonging to a given Compartment.
+ *
+ * @return Returns {@code ChildrenProvider} which fetches List of
+ * {@code BucketItem} for given {@code CompartmentItem}
+ */
+ public static ChildrenProvider<CompartmentItem, BucketItem> getBuckets() {
+ return compartmentId -> {
Review Comment:
Nitpick - naming: this is not a compartmentId, but the compartment itself
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/bucket/BucketNode.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.bucket;
+
+import com.oracle.bmc.objectstorage.ObjectStorageClient;
+import com.oracle.bmc.objectstorage.requests.ListBucketsRequest;
+import java.util.stream.Collectors;
+import org.netbeans.modules.cloud.oracle.ChildrenProvider;
+import org.netbeans.modules.cloud.oracle.NodeProvider;
+import org.netbeans.modules.cloud.oracle.OCIManager;
+import org.netbeans.modules.cloud.oracle.OCINode;
+import org.netbeans.modules.cloud.oracle.compartment.CompartmentItem;
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.openide.util.NbBundle;
+
+/**
+ *
+ * @author Jan Horvath
+ */
[email protected]({})
+public class BucketNode extends OCINode {
+
+ private static final String BUCKET_ICON =
"org/netbeans/modules/cloud/oracle/resources/bucket.svg"; // NOI18N
+
+ public BucketNode(BucketItem bucket) {
+ super(bucket);
+ setName(bucket.getName());
+ setDisplayName(bucket.getName());
+ setIconBaseWithExtension(BUCKET_ICON);
+ setShortDescription("Bucket: " + bucket.getName());
+ }
+
+ public static NodeProvider<BucketItem> createNode() {
+ return BucketNode::new;
+ }
+
+ /**
+ * Retrieves list of Vaults belonging to a given Compartment.
+ *
+ * @return Returns {@code ChildrenProvider} which fetches List of
+ * {@code BucketItem} for given {@code CompartmentItem}
+ */
+ public static ChildrenProvider<CompartmentItem, BucketItem> getBuckets() {
+ return compartmentId -> {
+ ObjectStorageClient client =
ObjectStorageClient.builder().build(OCIManager.getDefault().getActiveProfile().getConfigProvider());
Review Comment:
Q: wll `getActiveProfile` work well for non-active OCI trees (i.e. more
profiles in OCI config) ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/bucket/BucketItem.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.bucket;
+
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.netbeans.modules.cloud.oracle.items.OCIItem;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class BucketItem extends OCIItem {
+
+ private String namespace;
+
+ public BucketItem(OCID id, OCID compartment, String name, String
namespace) {
+ super(id, compartment, name);
+ this.namespace = namespace;
+ }
+
+ public BucketItem() {
+ super();
+ }
+
+ public String getNamespace() {
+ return namespace;
+ }
+
+ @Override
+ public int maxInProject() {
Review Comment:
Q: the base class impl returns `0`; is there a difference between "infinite"
value and 0 ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/SuggestedNode.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.assets;
+
+import org.netbeans.modules.cloud.oracle.NodeProvider;
+import org.netbeans.modules.cloud.oracle.OCINode;
+import org.netbeans.modules.cloud.oracle.items.OCIItem;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class SuggestedNode extends OCINode {
+
+ private static final String DB_ICON =
"org/netbeans/modules/cloud/oracle/resources/suggest.svg"; // NOI18N
Review Comment:
Nitpick: pasted naming, probably should be SUGGEST_ICON
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/SuggestedItem.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.assets;
+
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.netbeans.modules.cloud.oracle.items.OCIItem;
+
+/**
+ *
+ * @author honza
+ */
+public class SuggestedItem extends OCIItem {
Review Comment:
final ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/bucket/BucketItem.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.bucket;
+
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.netbeans.modules.cloud.oracle.items.OCIItem;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class BucketItem extends OCIItem {
Review Comment:
final ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/items/OCIItem.java:
##########
@@ -30,23 +30,26 @@
public abstract class OCIItem {
final OCID id;
final String name;
+ final OCID compartment;
Review Comment:
Q: why full `OCID` here, given that only compartment ID is acceptable ...
this leads to that each time `getCompartment()` is used for other purposes than
just create a peer item OCID, `getValue()` has to be called. Maybe a plain
String would be sufficient ? Depends on wheher it is more common to create
children of compartment (compartment OCID > String) or make OCI calls/peers
(Strings).
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/compute/ComputeInstanceItem.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.compute;
+
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.netbeans.modules.cloud.oracle.items.OCIItem;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class ComputeInstanceItem extends OCIItem {
Review Comment:
final ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/compute/ClusterNode.java:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.compute;
+
+import com.oracle.bmc.containerengine.ContainerEngineClient;
+import com.oracle.bmc.containerengine.requests.ListClustersRequest;
+import com.oracle.bmc.core.model.Instance;
+import java.util.stream.Collectors;
+import org.netbeans.modules.cloud.oracle.ChildrenProvider;
+import org.netbeans.modules.cloud.oracle.NodeProvider;
+import org.netbeans.modules.cloud.oracle.OCIManager;
+import org.netbeans.modules.cloud.oracle.OCINode;
+import org.netbeans.modules.cloud.oracle.compartment.CompartmentItem;
+import org.netbeans.modules.cloud.oracle.items.OCID;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class ClusterNode extends OCINode {
+ private static final String CLUSTER_ICON =
"org/netbeans/modules/cloud/oracle/resources/cluster.svg"; // NOI18N
+
+ public ClusterNode(ClusterItem cluster) {
+ super(cluster);
+ setName(cluster.getName());
+ setDisplayName(cluster.getName());
+ setIconBaseWithExtension(CLUSTER_ICON);
+ setShortDescription("Cluster: " + cluster.getName());
Review Comment:
I18N
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/compute/ComputeInstanceNode.java:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.compute;
+
+import com.oracle.bmc.core.ComputeClient;
+import com.oracle.bmc.core.model.Instance;
+import com.oracle.bmc.core.requests.ListInstancesRequest;
+import java.util.stream.Collectors;
+import org.netbeans.modules.cloud.oracle.ChildrenProvider;
+import org.netbeans.modules.cloud.oracle.NodeProvider;
+import org.netbeans.modules.cloud.oracle.OCIManager;
+import org.netbeans.modules.cloud.oracle.OCINode;
+import org.netbeans.modules.cloud.oracle.compartment.CompartmentItem;
+import org.netbeans.modules.cloud.oracle.items.OCID;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class ComputeInstanceNode extends OCINode {
+ private static final String COMPUTE_INSTANCE_ICON =
"org/netbeans/modules/cloud/oracle/resources/computeinstance.svg"; // NOI18N
+
+ public ComputeInstanceNode(ComputeInstanceItem instance) {
+ super(instance);
+ setName(instance.getName());
+ setDisplayName(instance.getName());
+ setIconBaseWithExtension(COMPUTE_INSTANCE_ICON);
+ setShortDescription("Compute Instance: " + instance.getName());
Review Comment:
I18N
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/compute/ClusterItem.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.cloud.oracle.compute;
+
+import org.netbeans.modules.cloud.oracle.items.OCID;
+import org.netbeans.modules.cloud.oracle.items.OCIItem;
+
+/**
+ *
+ * @author Jan Horvath
+ */
+public class ClusterItem extends OCIItem {
Review Comment:
final ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/items/TenancyItem.java:
##########
@@ -24,8 +24,8 @@
*/
public class TenancyItem extends OCIItem {
- public TenancyItem(OCID id, String name) {
- super(id, name);
+ public TenancyItem(OCID id, OCID compartment, String name) {
Review Comment:
Can `compartment` be non-null here ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/resources/layer.xml:
##########
@@ -34,6 +34,21 @@
</file>
<folder name="Oracle">
+ <folder name="Assets">
+ <file name="Assets.instance">
+ <attr name="instanceCreate"
methodvalue="org.netbeans.modules.cloud.oracle.assets.RootNode.instance"/>
+ <attr name="instanceClass"
stringvalue="org.openide.nodes.Node"/>
+ <attr name="instanceOf"
stringvalue="org.openide.nodes.Node"/>
+ </file>
+ </folder>
+ <folder name="Suggested">
+ <folder name="Nodes">
+ <file
name="org-netbeans-modules-cloud-oracle-SuggestedNode-listKnowledgeBases.instance">
Review Comment:
maybe bad copypaste naming -- listKnowledgeBases ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/resources/layer.xml:
##########
@@ -34,6 +34,21 @@
</file>
<folder name="Oracle">
+ <folder name="Assets">
+ <file name="Assets.instance">
+ <attr name="instanceCreate"
methodvalue="org.netbeans.modules.cloud.oracle.assets.RootNode.instance"/>
Review Comment:
Some leftover ? There does not seem to be `assets.RootNode` class in the PR.
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/vault/VaultNode.java:
##########
@@ -43,7 +44,7 @@ public VaultNode(VaultItem vault) {
setName(vault.getName());
setDisplayName(vault.getName());
setIconBaseWithExtension(VAULT_ICON);
- setShortDescription(vault.getDescription());
+ setShortDescription("OCI Vault: " + vault.getName());
Review Comment:
I18N
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
