mbien commented on code in PR #7391:
URL: https://github.com/apache/netbeans/pull/7391#discussion_r1609196940
##########
java/maven/src/org/netbeans/modules/maven/api/output/OutputUtils.java:
##########
@@ -263,9 +263,12 @@ protected ClassPath getClassPath() {
Project prj = ref.get();
if(prj != null) {
ProjectSourcesClassPathProvider prov =
prj.getLookup().lookup(ProjectSourcesClassPathProvider.class);
+ // appending compile cp probably doesn't hurt although
everything should be in exec cp already
return createProxyClassPath(
-
Stream.concat(Stream.of(prov.getProjectClassPaths(ClassPath.EXECUTE)),
-
Stream.of(prov.getProjectClassPaths(ClassPath.BOOT)))
+
Stream.of(Stream.of(prov.getProjectClassPaths(ClassPath.EXECUTE)),
+
Stream.of(prov.getProjectClassPaths(ClassPath.COMPILE)),
+
Stream.of(prov.getProjectClassPaths(ClassPath.BOOT)))
+ .flatMap(s -> s)
Review Comment:
everything should be in the exec cp I think, but
https://github.com/apache/netbeans/blob/139498df4577f8cfb1b6c76a1c30a4ca8002ea8b/java/maven/src/org/netbeans/modules/maven/classpath/ClassPathProviderImpl.java#L287
is difficult to debug due to all the lazy lambdas.
If tests have a module info (and src too), test sources seem to be missing
atm, adding compile cp fixes it and should have no side effects for the purpose
of opening stack trace links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
