matthiasblaesing commented on PR #7430: URL: https://github.com/apache/netbeans/pull/7430#issuecomment-2145711190
> Isn't this because the pcs and vcs in `TerminalInputOutput` are firing with the wrong source? No objection to fixing like this, but could be done without additional API. The source of the events is indeed the `TerminalInputOutput`, but the registration is not done on it. That is a capability implemented by the `IONotifier` implementation. This is hidden by the `IONotifier#addPropertyChangeListener` implementation. The problem is now, that to create a `WeakListener` you need access to the object you need to detach (in this case the `IONotifier` implementation) from when the listener is collected. I though about directly implementing the registration logic (essentially copying the `IONotifier#find` method), but discarded that so that the logic is all unified in `IONotifier`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
