neilcsmith-net commented on issue #4199: URL: https://github.com/apache/netbeans/issues/4199#issuecomment-2149205399
> Poorly generated hash codes are fairly common, so in practice a collision is a very real possibility (way more likely than 1/2^32). Of course (and records are fun for that!). The comment was partly facetious, certainly exaggerated, Although if using identity hashcodes, which could be forced, it's still unlikely to collide. And as a _mitigation_ and test, pending fixing properly, it's potentially useful. I only had a quick look at this, but the code that is meant to invalidate on lookup changes doesn't seem to fire. Certainly breakpoints in certain locations were not hit. Thanks @matthiasblaesing and like your comment on the curious hard-weak reference :smile: The other change would be to move the test into the right package - https://github.com/apache/netbeans/blob/master/platform/openide.awt/test/unit/src/org/netbeans/modules/openide/openide/awt/StatefulActionProcessorTest.java Although curiously while the IDE won't run it directly, CI is doing, which is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
