sdedic commented on PR #7433: URL: https://github.com/apache/netbeans/pull/7433#issuecomment-2151585638
Note that from a 'common' sense review (I've never worked with that API), the quality is ... strange. Take for example this: https://github.com/apache/netbeans/blob/master/ide/gsf.testrunner/src/org/netbeans/modules/gsf/testrunner/plugin/CommonTestUtilProvider.java#L31 which is not documented at all. The documentation is perhaps here: https://github.com/apache/netbeans/blob/master/java/java.testrunner/src/org/netbeans/modules/java/testrunner/CommonTestUtil.java#L286 - there's a fixed set of keys. The set is NOT extensible from other modules. - each key has its own data type, which is specified by the documentation ... that would normally lead to a final settings bean class or r/o class with a builder rather than untyped map. Nobody cared that much since it is a friend API with a limited impact, but if we **ever** make it public, it has to be maintained forever. Going public is the last chance the API can be cleaned up and made future-changes-compatible. It's not that just a "flag is flipped". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
