eirikbakke commented on PR #7465: URL: https://github.com/apache/netbeans/pull/7465#issuecomment-2166480364
> This part I wonder whether should be added to https://github.com/apache/netbeans-tools instead? Ah, that one seems like a better location; I wasn't entirely sure where to put the script. Though if there's ever a chance of the script becoming part of the official build process, then leaving it in this repo would make the git history cleaner. Potential future changes that might be relevant to whether the script might eventually become a part of the build process: * Perhaps we decide that it's better to copy in the SVGs at build time, to avoid having lots of of duplicate SVGs committed in the repo? Or perhaps not; there were other ideas floated before that did not involve a build step, such as having a centralized icon substitution mechanism in ImageUtilities. * Perhaps we revisit the idea of generating PNGs of different resolutions (e.g. [email protected], [email protected]) from the SVGs at build time instead of relying on the rather heavyweight NetBeans SVG loader. There are some use cases where SVGs won't load automatically, such as in image tags in a Swing HTML caption of a JLabel, or in image loading code generated by the NetBeans form builder. Happy to open a PR against netbeans-tools instead if you think that's the best place for these files. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
