mbien commented on code in PR #7502:
URL: https://github.com/apache/netbeans/pull/7502#discussion_r1650783595
##########
platform/openide.util.ui/test/unit/src/org/openide/xml/XMLUtilTest2.java:
##########
@@ -49,9 +49,9 @@
import org.xml.sax.SAXParseException;
import org.xml.sax.helpers.DefaultHandler;
-public class XMLUtilTest extends NbTestCase {
+public class XMLUtilTest2 extends NbTestCase {
Review Comment:
adding the `2` does disable the test?
##########
platform/openide.nodes/src/org/openide/nodes/Children.java:
##########
@@ -1942,15 +1942,9 @@ private Mutex callPMMutexMethod() {
clazz =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.api.project.ProjectManager");
// NOI18N
method = clazz.getMethod("mutex"); // NOI18N
return (Mutex) method.invoke(null);
- } catch (ClassNotFoundException e) {
- return FALLBACK;
- } catch (IllegalAccessException e) {
- return FALLBACK;
- } catch (IllegalArgumentException e) {
- return FALLBACK;
- } catch (InvocationTargetException e) {
- return FALLBACK;
- } catch (NoSuchMethodException e) {
+ } catch (ExceptionInInitializerError | ClassNotFoundException
+ | IllegalAccessException | IllegalArgumentException
+ | InvocationTargetException | NoSuchMethodException e) {
Review Comment:
nitpick: `ReflectiveOperationException | ExceptionInInitializerError |
IllegalArgumentException`
##########
platform/openide.util.ui/test/unit/src/org/openide/xml/XMLUtilTest2.java:
##########
@@ -364,7 +364,11 @@ public void testSignificantWhitespace() throws Exception {
String data =
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
"<r>\n" +
- " <p>This is <em>not</em> a test!</p>\n" +
Review Comment:
i remember looking at this before and I couldn't figure out if the test was
supposed to assert that NB isn't re-formatting the code or if is about
something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
