matthiasblaesing commented on PR #7533: URL: https://github.com/apache/netbeans/pull/7533#issuecomment-2204326939
This will fail. The class `org.netbeans.modules.docker.api.DockerImage` is part of the API of the module and thus removing `getVirtualSize` is an incompatbile change. The API is "friend only" (only explicitly listed other modules can access it), but still an API. From my understanding "Virtual Size" never made sense for images, just for containers, as the image are the readonly portion and only a running container has a writable part. So wouldn't it make sense to use `getOrDefault` also for virtual size and use the value from `Size` as fallback? On my admittingly small setup, this seems to be truthy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
