mbien commented on code in PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#discussion_r1653773734
##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/MavenCoordinate.java:
##########
@@ -83,6 +83,11 @@ public String toMavenPath() {
}
public static boolean isMavenFile(String gradleFormat) {
+ if (gradleFormat.startsWith("http://";) ||
+ gradleFormat.startsWith("https://";) ||
+ gradleFormat.startsWith("file://")) {
+ return false;
+ }
return gradleFormat.split(":").length > 2;
}
Review Comment:
curious: what is this for? `hash url filename` did work before this change
already, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
